On Thu, May 17, 2018 at 12:13:07AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-16 18:32:31 +0200, Jacopo Mondi wrote: > > The 'bus-width' and 'pclk-sample' properties are not parsed by the VIN > > driver and only confuse users. Remove them in all Gen2 SoC that used > > them. > > > > Signed-off-by: Jacopo Mondi <[email protected]> > > --- > > arch/arm/boot/dts/r8a7790-lager.dts | 3 --- > > arch/arm/boot/dts/r8a7791-koelsch.dts | 3 --- > > arch/arm/boot/dts/r8a7791-porter.dts | 1 - > > arch/arm/boot/dts/r8a7793-gose.dts | 3 --- > > arch/arm/boot/dts/r8a7794-alt.dts | 1 - > > arch/arm/boot/dts/r8a7794-silk.dts | 1 - > > 6 files changed, 12 deletions(-) > > > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts > > b/arch/arm/boot/dts/r8a7790-lager.dts > > index 063fdb6..b56b309 100644 > > --- a/arch/arm/boot/dts/r8a7790-lager.dts > > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > > @@ -873,10 +873,8 @@ > > port { > > vin0ep2: endpoint { > > remote-endpoint = <&adv7612_out>; > > - bus-width = <24>; > > I can't really make up my mind if this is a good thing or not. Device > tree describes the hardware and not what the drivers make use of. And > the fact is that this bus is 24 bits wide. So I'm not sure we should > remove these properties. But I would love to hear what others think > about this.
IMO, this property should only be present when all the pins are not connected. And by "all", I mean the minimum of what each end of the graph can support. Rob
