On 2018-07-12 19:49, Wolfram Sang wrote:
> When we we initialize the pins, make sure it looks like STOP by dividing
> the delay into halves. It shouldn't matter because SDA is expected to be
> held low by a device, but for super-safety, let's do it.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
> drivers/i2c/i2c-core-base.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
> index 51cbb0c158f2..e57231ccb32a 100644
> --- a/drivers/i2c/i2c-core-base.c
> +++ b/drivers/i2c/i2c-core-base.c
> @@ -191,9 +191,10 @@ int i2c_generic_scl_recovery(struct i2c_adapter *adap)
> bri->prepare_recovery(adap);
>
> bri->set_scl(adap, scl);
For me, it would be more natural to have
bri->set_scl(adap, 1);
> + ndelay(RECOVERY_NDELAY / 2);
> if (bri->set_sda)
> - bri->set_sda(adap, 1);
> - ndelay(RECOVERY_NDELAY);
> + bri->set_sda(adap, scl);
instead of changing this "1" to "scl"? Same-same, but it looks odd
to use scl as argument to sda (at least without that comment about
sda following scl that is present inside the loop below).
At the same time, your version make the code inside the loop the
same as this initializing code. Oh well, your call...
Either way
Reviewed-by: Peter Rosin <[email protected]>
Cheers,
Peter
> + ndelay(RECOVERY_NDELAY / 2);
>
> /*
> * By this time SCL is high, as we need to give 9 falling-rising edges
>
