On Wed, Jul 18, 2018 at 10:54:08AM +0200, Simon Horman wrote: > Hi Niklas, > > On Tue, Jul 17, 2018 at 04:52:16PM +0200, Niklas Söderlund wrote: > > From: Masaharu Hayakawa <[email protected]> > > > > Checking for SCC error during retuning is unnecessary. > > > > Signed-off-by: Masaharu Hayakawa <[email protected]> > > [Niklas: fix small style issue] > > Signed-off-by: Niklas Söderlund <[email protected]> > > Tested-by: Wolfram Sang <[email protected]> > > Reviewed-by: Wolfram Sang <[email protected]>
Sorry, Niklas, I got confused with the messages, that's my fault. I want
to revoke my tags here which were meant for another patch in your
series. I actually wanted to write a comment about...
> >
> > ---
> >
> > * Changes since v2
> > - Added check for HS400 as it's now merged.
> > - Added tags from Wolfram.
> > ---
> > drivers/mmc/host/renesas_sdhi_core.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/mmc/host/renesas_sdhi_core.c
> > b/drivers/mmc/host/renesas_sdhi_core.c
> > index 777e32b0e410e850..a21b347424f67c52 100644
> > --- a/drivers/mmc/host/renesas_sdhi_core.c
> > +++ b/drivers/mmc/host/renesas_sdhi_core.c
> > @@ -444,6 +444,14 @@ static bool renesas_sdhi_check_scc_error(struct
> > tmio_mmc_host *host)
> > {
> > struct renesas_sdhi *priv = host_to_priv(host);
> >
> > + if (!(host->mmc->ios.timing == MMC_TIMING_UHS_SDR104) &&
> > + !(host->mmc->ios.timing == MMC_TIMING_MMC_HS200) &&
> > + !(host->mmc->ios.timing == MMC_TIMING_MMC_HS400))
>
> According to the BSP this needs to differentiate between 4tap and 8tap
> variants of HS400 support.
... checking exactly this.
signature.asc
Description: PGP signature
