Hi Chris,
On Thu, Jul 26, 2018 at 2:14 PM Chris Brandt <[email protected]> wrote:
> On Thursday, July 26, 2018, Geert Uytterhoeven wrote:
> > On Wed, Jul 25, 2018 at 4:39 PM Chris Brandt <[email protected]>
> > wrote:
> > > Some devices with SCIx_SH4_SCIF_REGTYPE have no space between registers.
> > > Use the register area size to determine the spacing between register.
> > >
> > > Signed-off-by: Chris Brandt <[email protected]>
> >
> > Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> Thank you.
>
> > > + if (p->regtype == SCIx_SH4_SCIF_REGTYPE)
> > > + if (sci_port->reg_size >= 0x20)
> > > + port->regshift = 1;
> > > +
> >
> > So you have to be careful not to round up the reg size in DT to the next
> > power of two (0x20), like you did for RZ/A1 (64 is used there).
>
> Me????
> It was Wolfram that committed the RZ/A1 DT scif code back in 2014 ;)
I stand corrected.
(and RZLSP didn't use resources yet, but the old mapbase, so there are no
sizes ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
