On Tue, Feb 19, 2019 at 06:24:20PM +0100, Wolfram Sang wrote:
> On Sun, Feb 17, 2019 at 02:24:41PM +0100, [email protected] wrote:
> > From: Kazufumi Ikeda <[email protected]>
> > 
> > Reestablish the PCIe link very early in the resume process in case it
> > went down to prevent PCI accesses from hanging the bus. Such accesses
> > can happen early in the PCI resume process, in the resume_noirq, thus
> > the link must be reestablished in the resume_noirq callback of the
> > driver.
> > 
> > Signed-off-by: Kazufumi Ikeda <[email protected]>
> > Signed-off-by: Gaku Inami <[email protected]>
> > Signed-off-by: Marek Vasut <[email protected]>
> 
> I am not a deep PCI expert. Still, the patch looks good to me and I
> double checked with the documentation.
> 
> Acked-by: Wolfram Sang <[email protected]>
> 
> Minor nit would be 'CONFIG_PM' protection around the new code. But I
> have no strong opinion on that.

I agree that would be a nice enhancement but I also do not feel strongly
about it.

Reviewed-by: Simon Horman <[email protected]>

Reply via email to