Hi Simon,
On 2019-04-08 14:29:41 +0200, Simon Horman wrote:
> > > @@ -3172,11 +3158,15 @@
> > >
> > > cooling-maps {
> > > map0 {
> > > - trip = <&sensor3_passive>;
> > > - cooling-device = <&a57_0 4 4>,
> > > - <&a57_1 4 4>,
> > > - <&a57_2 4 4>,
> > > - <&a57_3 4 4>;
> > > + trip = <&target>;
> > > + cooling-device = <&a57_0 0 2>;
> >
> > We have 5 (0-4) cooling states for the A57s on this SoC. Out of
> > curiosity why allow states 0-2 here and not force it do more cooling or
> > keep the to max cooling (4) as before this change as this is set to a
> > trip point with a rather large temperature? Not saying this is wrong
> > only curious :-)
>
> This I do not know. Do you think it would be worth following-up on
> internally?
I'm no expert on this but I think it could be educational to learn why
not the full range is used. Still this might be correct so I don't want
to block this patch based on my ignorance.
--
Regards,
Niklas Söderlund
