Hi Laurent, Thanks for the feedback.
> Subject: Re: [PATCH v2 9/9] arm64: dts: renesas: Add support for Advantech > idk-1110wr LVDS panel > > Hi Biju, > > Thank you for the patch. > > On Wed, Oct 02, 2019 at 11:08:26AM +0100, Biju Das wrote: > > This patch adds support for Advantech idk-1110wr LVDS panel. > > The HiHope RZ/G2[MN] is advertised as compatible with panel idk-1110wr > > from Advantech, however the panel isn't sold alongside the board. > > > > Signed-off-by: Biju Das <[email protected]> > > --- > > V1-->V2 > > * Incorporated Laurent's review comments > > --- > > .../renesas/rzg2-advantech-idk-1110wr-panel.dtsi | 42 > ++++++++++++++++++++++ > > 1 file changed, 42 insertions(+) > > create mode 100644 > > arch/arm64/boot/dts/renesas/rzg2-advantech-idk-1110wr-panel.dtsi > > > > diff --git > > a/arch/arm64/boot/dts/renesas/rzg2-advantech-idk-1110wr-panel.dtsi > > b/arch/arm64/boot/dts/renesas/rzg2-advantech-idk-1110wr-panel.dtsi > > new file mode 100644 > > index 0000000..4f876df > > --- /dev/null > > +++ b/arch/arm64/boot/dts/renesas/rzg2-advantech-idk-1110wr- > panel.dtsi > > @@ -0,0 +1,42 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Device Tree Source for the Advantech idk-1110wr LVDS panel > > +connected > > + * to RZ/G2 boards > > + * > > + * Copyright (C) 2019 Renesas Electronics Corp. > > + */ > > + > > +/ { > > + OK. Will fix this. > No need for a blank line here. Apart from this, > > Reviewed-by: Laurent Pinchart <[email protected]> > > > + panel-lvds { > > + compatible = "advantech,idk-1110wr", "panel-lvds"; > > + > > + width-mm = <223>; > > + height-mm = <125>; > > + > > + data-mapping = "jeida-24"; > > + > > + panel-timing { > > + /* 1024x600 @60Hz */ > > + clock-frequency = <51200000>; > > + hactive = <1024>; > > + vactive = <600>; > > + hsync-len = <240>; > > + hfront-porch = <40>; > > + hback-porch = <40>; > > + vfront-porch = <15>; > > + vback-porch = <10>; > > + vsync-len = <10>; > > + }; > > + > > + port { > > + panel_in: endpoint { > > + remote-endpoint = <&lvds_connector>; > > + }; > > + }; > > + }; > > +}; > > + > > +&lvds_connector { > > + remote-endpoint = <&panel_in>; > > +}; > > -- > Regards, > > Laurent Pinchart
