Hi Laurent, On 18/04/2019 07:32, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thu, Apr 11, 2019 at 05:12:53PM +0100, Kieran Bingham wrote: >> Ensure that the partition window is correctly initialised before being >> utilised. >> >> Signed-off-by: Kieran Bingham <[email protected]> >> --- >> drivers/media/platform/vsp1/vsp1_video.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/vsp1/vsp1_video.c >> b/drivers/media/platform/vsp1/vsp1_video.c >> index ee2fb8261a6a..563f9a02c373 100644 >> --- a/drivers/media/platform/vsp1/vsp1_video.c >> +++ b/drivers/media/platform/vsp1/vsp1_video.c >> @@ -189,7 +189,7 @@ static void vsp1_video_calculate_partition(struct >> vsp1_pipeline *pipe, >> unsigned int index) >> { >> const struct v4l2_mbus_framefmt *format; >> - struct vsp1_partition_window window; >> + struct vsp1_partition_window window = { 0, }; > > This isn't needed as-is. If this change is required by a patch further > in this series, you can squash it there.
Ok, I think this might have got put in because of my debug patch which prints the tables and was showing uninitialised data in unused fields. I guess they can stay uninitiailised if/when they are unused :D. > >> unsigned int modulus; >> >> /* >
