On Thu, Oct 7, 2010 at 10:33 AM, Seungwhan Youn <[email protected]> wrote: > Dear Maintainers, > >>> >> plat-samsung would probably be fine for that also - create a file called >>> >> common-smdk or something. Some other things have gone for a plat-smdk >>> >> style approach too, though I'm not sure how tasteful I find that >>> >> personally. >>> > Even though I would personally like to have EPLL control for a device >>> > in machine specific manner as part of its driver, I accept your opinion. >>> > >>> > Claude, let us create one arch/arm/plat-samsung/smdk.c to do common >>> > stuff for SMKDs like EPLL control. What do you think ? >>> >>> Actually if we add this file on plat-samsung, board-init will be >>> separated two-part, one is machine(board) specific and other is all >>> smdk specific. So, If it doesn't make confusion to other guys who >>> wants to add settings for their features on board-init, it looks good >>> to me. But I think that we also have to listen Mr. Ben Dooks and Mr. >>> Kukjin Kim's opinion about this before we get a conclusion. >> >> Hi all, >> >> I think, basically it'd better if could control clock stuff in each driver >> for it when need it such as clk_get, clk_enable and so on. >> Actually there is no policy/protection for EPLL usage in plat-samsung or >> plat-s5p now and need to sort out other similar case for it also....so in my >> opinion, right now to proceed with the current style is helpful to me and >> will consider it in the future. >> > > I wander to know that this is a last discussion, or more, and also > know about finial decision. Of course, if we didn't get reached to the > conclusion, we can talk more. > > Can you give me a hand to finish this? :-) >
Dear Mr. Mark and Mr. Jassi, Now, I'm almost finished 2nd patch for submit except this audio clock setting. For now, I can only think that remove audio clock setting from this machine code, and add audio clock settings in arch later(may be after arch/arm/plat-samsung get EPLL policy as Mr. Kukjin said). Is this okay? BRs, Claude. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
