On Tue, 2011-12-13 at 22:22 +0200, Denis Kuzmenko wrote: > Make s3c24xx LEDS driver use gpiolib. Fix error disabling pull during probe. [] > diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c [] > @@ -45,23 +45,35 @@ static void s3c24xx_led_set(struct led_classdev *led_cdev, > + /* > + * ensure value is 0 or 1 to use it with bitwise XOR (^) > + * (only 100% brightness is supported) > + */ > + value = value ? 1 : 0;
Maybe value = !!value; > + /* no point in having a pull-up as we are always driving */ > + s3c_gpio_setpull(pdata->gpio, S3C_GPIO_PULL_NONE); > + ret = gpio_direction_output(pdata->gpio, > + !!(pdata->flags & S3C24XX_LEDF_ACTLOW)); akin to this use. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
