On Tuesday, July 30, 2013 8:20 PM, Vikas Sajjan wrote:
>
> Moves the properties of DP controller to exynos5.dtsi which are common
> across exynos5 SoCs like Exynos5250 and Exynos5420.
> 
> The PHY DP Node is based on Jingoo Han's <[email protected]> patch at
> https://patchwork.linuxtv.org/patch/19189/
> 
> Signed-off-by: Vikas Sajjan <[email protected]>
> ---
>  arch/arm/boot/dts/exynos5.dtsi            |   11 +++++++++++
>  arch/arm/boot/dts/exynos5250-arndale.dts  |    3 ++-
>  arch/arm/boot/dts/exynos5250-smdk5250.dts |    3 ++-
>  arch/arm/boot/dts/exynos5250.dtsi         |   21 +++++++++------------
>  4 files changed, 24 insertions(+), 14 deletions(-)
>  

[....]

> diff --git a/arch/arm/boot/dts/exynos5250.dtsi 
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 238bdb2..1c017dc 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -614,20 +614,17 @@
>               interrupts = <0 94 0>;
>       };
> 
> -     dp-controller {
> -             compatible = "samsung,exynos5-dp";
> -             reg = <0x145b0000 0x1000>;
> -             interrupts = <10 3>;
> -             interrupt-parent = <&combiner>;
> +     dp_phy: video-phy@10040720 {
> +             compatible = "samsung,exynos5250-dp-video-phy";
> +             reg = <0x10040720 4>;
> +             #phy-cells = <0>;
> +     };

Oops!!!

This patch should be reverted.
Or, fix patch should be re-sent.
'dp phy' driver is not yet merged to mainline kernel.


> +
> +     dp-controller@145b0000 {
>               clocks = <&clock 342>;
>               clock-names = "dp";
> -             #address-cells = <1>;
> -             #size-cells = <0>;
> -
> -             dptx-phy {
> -                     reg = <0x10040720>;
> -                     samsung,enable-mask = <1>;
> -             };
> +             phys = <&dp_phy>;
> +             phy-names = "dp";
>       };

Thus, 'dptx-phy' node should be used until dp phy driver is merged.

Vikas Sajjan,
Please test your patch on real boards when you send your patch.


Best regards,
Jingoo Han



--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to