Hi Mr. Jingoo Han,
On 26 August 2013 08:27, Jingoo Han <[email protected]> wrote:
> On Tuesday, July 30, 2013 8:20 PM, Vikas Sajjan wrote:
>>
>> Moves the properties of DP controller to exynos5.dtsi which are common
>> across exynos5 SoCs like Exynos5250 and Exynos5420.
>>
>> The PHY DP Node is based on Jingoo Han's <[email protected]> patch at
>> https://patchwork.linuxtv.org/patch/19189/
>>
>> Signed-off-by: Vikas Sajjan <[email protected]>
>> ---
>> arch/arm/boot/dts/exynos5.dtsi | 11 +++++++++++
>> arch/arm/boot/dts/exynos5250-arndale.dts | 3 ++-
>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 3 ++-
>> arch/arm/boot/dts/exynos5250.dtsi | 21 +++++++++------------
>> 4 files changed, 24 insertions(+), 14 deletions(-)
>>
>
> [....]
>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> index 238bdb2..1c017dc 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -614,20 +614,17 @@
>> interrupts = <0 94 0>;
>> };
>>
>> - dp-controller {
>> - compatible = "samsung,exynos5-dp";
>> - reg = <0x145b0000 0x1000>;
>> - interrupts = <10 3>;
>> - interrupt-parent = <&combiner>;
>> + dp_phy: video-phy@10040720 {
>> + compatible = "samsung,exynos5250-dp-video-phy";
>> + reg = <0x10040720 4>;
>> + #phy-cells = <0>;
>> + };
>
> Oops!!!
>
> This patch should be reverted.
> Or, fix patch should be re-sent.
> 'dp phy' driver is not yet merged to mainline kernel.
>
As you suggest, since the DP-PHY driver is NOT yet in mainline, we may
have to keep this patch reverted till your patch series gets merged to
have DP working on exynos5 .
>
>> +
>> + dp-controller@145b0000 {
>> clocks = <&clock 342>;
>> clock-names = "dp";
>> - #address-cells = <1>;
>> - #size-cells = <0>;
>> -
>> - dptx-phy {
>> - reg = <0x10040720>;
>> - samsung,enable-mask = <1>;
>> - };
>> + phys = <&dp_phy>;
>> + phy-names = "dp";
>> };
>
> Thus, 'dptx-phy' node should be used until dp phy driver is merged.
>
> Vikas Sajjan,
> Please test your patch on real boards when you send your patch.
>
I tested the patch before sending on Exynos5250-SMDK5250 using Kishon
Vijay Abraham's series at http://lwn.net/Articles/559487/
which contains DP-PHY driver posted by you
1. phy: Add driver for Exynos DP PHY
2. video: exynos_dp: remove non-DT support for Exynos Display Port
3. video: exynos_dp: Use the generic PHY driver
>
> Best regards,
> Jingoo Han
>
>
>
--
Thanks and Regards
Vikas Sajjan
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
