Hi Arun,

On 14.04.2014 08:35, Arun Kumar K wrote:
The newer versions of exynos5250 based Snow boards have
atmel trackpad. Updating relevant nodes for the same.

Signed-off-by: Arun Kumar K <arun...@samsung.com>
---
  arch/arm/boot/dts/exynos5250-cros-common.dtsi |   24 ++++++++++++++++++++++++
  1 file changed, 24 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-cros-common.dtsi 
b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
index 2c1560d..658f086 100644
--- a/arch/arm/boot/dts/exynos5250-cros-common.dtsi
+++ b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
@@ -28,6 +28,13 @@
                        samsung,pin-pud = <0>;
                };

+               trackpad_irq: trackpad-irq {
+                       samsung,pins = "gpx1-2";
+                       samsung,pin-function = <0>;
+                       samsung,pin-pud = <0>;
+                       samsung,pin-drv = <0>;
+               };
+
                max77686_irq: max77686-irq {
                        samsung,pins = "gpx3-2";
                        samsung,pin-function = <0>;
@@ -191,6 +198,9 @@
                samsung,i2c-sda-delay = <100>;
                samsung,i2c-max-bus-freq = <378000>;

+               pinctrl-names = "default";
+               pinctrl-0 = <&i2c1_bus &trackpad_irq>;

Please add &trackpad_irq to trackpad node instead. Pinctrl properties of i2c node should contain only i2c-related pins.

+
                trackpad {
                        reg = <0x67>;
                        compatible = "cypress,cyapa";
@@ -198,6 +208,20 @@
                        interrupt-parent = <&gpx1>;
                        wakeup-source;
                };
+               trackpad-alt {

Style: Please keep one blank line between two nodes.

+                       reg = <0x4b>;
+                       compatible = "atmel,atmel_mxt_tp";
+                       interrupts = <2 0>;
+                       interrupt-parent = <&gpx1>;
+                       wakeup-source;
+               };
+               trackpad-bootloader {

Ditto.

+                       reg = <0x25>;
+                       compatible = "atmel,atmel_mxt_tp";
+                       interrupts = <2 0>;
+                       interrupt-parent = <&gpx1>;
+                       wakeup-source;
+               };

Hmm, why are there 3 different nodes here? Could you explain what one by one for what hardware they are?

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to