"erich" <[EMAIL PROTECTED]> wrote: > > I have contact with Andrew Morton about ARECA RAID Linux scsi driver release > issue. > I hope this package is as look like a Linux driver.
No, it doesn't look anything like a Linux driver :( I fed the patch through scripts/Lindent. There's a copy at http://www.zip.com.au/~akpm/linux/patches/stuff/areca-raid-linux-scsi-driver.patch. I'll include it -mm kernels. >From a very quick look, I'd say that the driver needs quite a bit of work: - Remove Documentation/scsi/arcmsr.txt - none of it is relevant - Use named structure initialisers: struct foo bar = { .name1 = value1, .name2 = value2, }; - Remove all the LINUX_VERSION_CODE tests - The kernel thread stopping/starting stuff is old fashioned. Use the kthread API. - I suspect it is using old-fashioned SCSI APIs too. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
