On Mon, Feb 21, 2005 at 02:02:21AM +0000, Matthew Wilcox wrote:
> On Sun, Feb 20, 2005 at 08:11:58PM -0500, Jeff Garzik wrote:
> > Patch doesn't apply with -p1.
>
> Doesn't matter; I can cope with both.
Irrelevant. It matters to automated patch snarfers, lkml.org users, etc.
> > >--- drivers/scsi/sym53c8xx_2/sym_glue.c 20 Feb 2005 23:49:27 -0000
> > >1.84
> >
> > This file does not include <linux/config.h>.
>
> Doesn't need to -- sym_glue.h does.
>
> > >--- drivers/scsi/sym53c8xx_2/sym_hipd.c 16 Feb 2005 20:54:02 -0000
> > >1.48
> >
> > ditto
>
> ditto.
Incorrect. <linux/config.h> is not a standard include; you need to
include linux/config.h in each file that uses a CONFIG_xxx define.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
