On Sun, Feb 20, 2005 at 09:16:31PM -0500, Jeff Garzik wrote:
> On Mon, Feb 21, 2005 at 02:14:05AM +0000, Matthew Wilcox wrote:
> > On Sun, Feb 20, 2005 at 09:09:36PM -0500, Jeff Garzik wrote:
> > > Incorrect.  <linux/config.h> is not a standard include; you need to
> > > include linux/config.h in each file that uses a CONFIG_xxx define.
> > 
> > sym_hipd.c includes "sym_glue.h"
> > sym_glue.h includes <linux/config.h>
> > There is no problem.
> 
> Irrelevant.  Go look at how config.h stuff works.
> 
> linux/config.h is a special case with special rules.
> 
> The rule is:  include linux/config.h _in the file_ where CONFIG_xxx
> symbol is used.

Jeff, you're smoking crack.  I just read fixdep.c and looked at
drivers/scsi/sym53c8xx_2/.sym_hipd.o.cmd .  You're wrong.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to