The new cardtype was a documentation. Could have been handled separately I agree.
*I* have to support the broken port for reasons of expediency. Dropping this behavior from the kernel.org patch is perfectly fine by me. I was not sure how extensive this problem was. Sincerely -- Mark Salyzyn -----Original Message----- From: Christoph Hellwig [mailto:[EMAIL PROTECTED] Sent: Monday, March 28, 2005 5:00 PM To: Mark Haverkamp Cc: James Bottomley; linux-scsi; Salyzyn, Mark Subject: Re: [PATCH] 2.6 aacraid: endian cleanup On Mon, Mar 21, 2005 at 10:41:23AM -0800, Mark Haverkamp wrote: > A patch from Adaptec with byte order changes: > - drop byte swapping on all 0's and all 1's content > - fix up missing swapping directives > - ensure swapping on 16 bit values does not use 32 bit swap > - reconcile the readl/writel auto-swapping in only most of the > configurations. that last bit is bogus. readl/writel are defined to swap bytes on big endian systems. Whatever broken Mvista/Windriver or whatever port doesn't do that should be fixed. Also please remove unrelated changes like the new cardtypes from the patch, follow normal kernel codingstyle (e.g. ||, && at the end of the line) and switch to __le* types for harware structures and make sure it's passing sparse -Wbitwise. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
