Re: [PATCH 01/10] qla2xxx: Clean up qla24xx_iidma()

[Saurav Kashyap]

Hi Bart,
Missing msg ids needs to be updated in qla_dbg.c file. Here is an updated
patch

diff --git a/drivers/scsi/qla2xxx/qla_bsg.c
b/drivers/scsi/qla2xxx/qla_bsg.c
index 89dd050..25ded57 100644
--- a/drivers/scsi/qla2xxx/qla_bsg.c
+++ b/drivers/scsi/qla2xxx/qla_bsg.c
@@ -1282,14 +1282,7 @@ qla24xx_iidma(struct fc_bsg_job *bsg_job)
                return -EINVAL;
        }
 
-       port_param = (struct qla_port_param *)((char *)bsg_job->request +
-               sizeof(struct fc_bsg_request));
-       if (!port_param) {
-               ql_log(ql_log_warn, vha, 0x7047,
-                   "port_param header not provided.\n");
-               return -EINVAL;
-       }
-
+       port_param = (void *)bsg_job->request + sizeof(struct
fc_bsg_request);
        if (port_param->fc_scsi_addr.dest_type != EXT_DEF_TYPE_WWPN) {
                ql_log(ql_log_warn, vha, 0x7048,
                    "Invalid destination type.\n");
diff --git a/drivers/scsi/qla2xxx/qla_dbg.c
b/drivers/scsi/qla2xxx/qla_dbg.c
index 94f3a25..980dcbc 100644
--- a/drivers/scsi/qla2xxx/qla_dbg.c
+++ b/drivers/scsi/qla2xxx/qla_dbg.c
@@ -35,7 +35,8 @@
  * |                              |                    | 0x70a5,0x70a6, |
  * |                              |                    | 0x70a8,0x70ab, |
  * |                              |                    | 0x70ad-0x70ae, |
- * |                              |                    | 0x70d1-0x70da  |
+ * |                              |                    | 0x70d1-0x70da, |
+ * |                              |                    | 0x7047
     |
  * | Task Management              |       0x803c       | 0x8025-0x8026  |
  * |                              |                    | 0x800b,0x8039  |
  * | AER/EEH                      |       0x9011       |               |


Thanks,
~Saurav



>Remove dead code and simplify a pointer computation.
>
>Signed-off-by: Bart Van Assche <bvanass...@acm.org>
>Cc: Chad Dupuis <chad.dup...@qlogic.com>
>Cc: Saurav Kashyap <saurav.kash...@qlogic.com>
>---
> drivers/scsi/qla2xxx/qla_bsg.c |    9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
>diff --git a/drivers/scsi/qla2xxx/qla_bsg.c
>b/drivers/scsi/qla2xxx/qla_bsg.c
>index 39719f8..7221521 100644
>--- a/drivers/scsi/qla2xxx/qla_bsg.c
>+++ b/drivers/scsi/qla2xxx/qla_bsg.c
>@@ -1282,14 +1282,7 @@ qla24xx_iidma(struct fc_bsg_job *bsg_job)
>               return -EINVAL;
>       }
> 
>-      port_param = (struct qla_port_param *)((char *)bsg_job->request +
>-              sizeof(struct fc_bsg_request));
>-      if (!port_param) {
>-              ql_log(ql_log_warn, vha, 0x7047,
>-                  "port_param header not provided.\n");
>-              return -EINVAL;
>-      }
>-
>+      port_param = (void *)bsg_job->request + sizeof(struct fc_bsg_request);
>       if (port_param->fc_scsi_addr.dest_type != EXT_DEF_TYPE_WWPN) {
>               ql_log(ql_log_warn, vha, 0x7048,
>                   "Invalid destination type.\n");
>-- 
>1.7.10.4
>

<<attachment: winmail.dat>>