Acked-by: Saurav Kashyap <[email protected]>
>Since the value of cur_seg is not used and since scsi_prot_sglist() >has no side effects it is safe to remove the statement >"cur_seg = scsi_prot_sglist(cmd)". Detected by Coverity. > >Signed-off-by: Bart Van Assche <[email protected]> >Cc: Chad Dupuis <[email protected]> >Cc: Saurav Kashyap <[email protected]> >--- > drivers/scsi/qla2xxx/qla_iocb.c | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/drivers/scsi/qla2xxx/qla_iocb.c >b/drivers/scsi/qla2xxx/qla_iocb.c >index 15e4080..b589d24 100644 >--- a/drivers/scsi/qla2xxx/qla_iocb.c >+++ b/drivers/scsi/qla2xxx/qla_iocb.c >@@ -1189,7 +1189,6 @@ qla24xx_build_scsi_crc_2_iocbs(srb_t *sp, struct >cmd_type_crc_2 *cmd_pkt, > uint32_t *cur_dsd, *fcp_dl; > scsi_qla_host_t *vha; > struct scsi_cmnd *cmd; >- struct scatterlist *cur_seg; > int sgc; > uint32_t total_bytes = 0; > uint32_t data_bytes; >@@ -1396,7 +1395,6 @@ qla24xx_build_scsi_crc_2_iocbs(srb_t *sp, struct >cmd_type_crc_2 *cmd_pkt, > > if (bundling && tot_prot_dsds) { > /* Walks dif segments */ >- cur_seg = scsi_prot_sglist(cmd); > cmd_pkt->control_flags |= > __constant_cpu_to_le16(CF_DIF_SEG_DESCR_ENABLE); > cur_dsd = (uint32_t *) &crc_ctx_pkt->u.bundling.dif_address; >-- >1.7.10.4 > >
<<attachment: winmail.dat>>
