On 12/04/2014 10:17 AM, Christoph Hellwig wrote:
>> -#define AdvAbortQueue(asc_dvc, scsiq) \
>> +#define AdvAbortQueue(asc_dvc, srb_tag) \
>>          AdvSendIdleCmd((asc_dvc), (ushort) IDLE_CMD_ABORT, \
>> -                       (ADV_DCNT) (scsiq))
>> +                       (ADV_DCNT) (srb_tag))
> 
> This change looks unrelated.
> 
Yes, correct. This needs to be moved to the next patch.

>> @@ -11250,7 +11250,7 @@ static struct scsi_host_template advansys_template = 
>> {
>>      .name = DRV_NAME,
>>      .info = advansys_info,
>>      .queuecommand = advansys_queuecommand,
>> -    .eh_bus_reset_handler = advansys_reset,
>> +    .eh_host_reset_handler = advansys_reset,
> 
> Please also update the comments in advansys_reset that talk about bus
> resets and in one case event about a device reset.
> 
Okay.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                   zSeries & Storage
[email protected]                          +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to