On 12/04/2014 10:20 AM, Christoph Hellwig wrote:
>>  typedef struct asc_scsiq_2 {
>> -    ASC_VADDR srb_ptr;
>> +    __le32 srb_tag;
> 
> Given that the tag has no meaning for the hardware why do you
> want to endian switch it?  Keeping the ASC_VADDR for now makes
> it easier to verify the hardware structures don't change.
> 
Mhm. See the patch I've just sent to Ondrej.
For the narrow board it actually _has_ a meaning.
But okay, the endian switch is probably pointless here.

>> @@ -6132,6 +6077,13 @@ static void adv_async_callback(ADV_DVC_VAR 
>> *adv_dvc_varp, uchar code)
>>              AdvResetChipAndSB(adv_dvc_varp);
>>              break;
>>  
>> +    case ADV_ASYNC_CARRIER_READY_FAILURE:
>> +            /*
>> +             * Carrier not ready; abort the command.
>> +             */
>> +            ASC_DBG(0, "ADV_ASYNC_CARRIER_READY_FAILURE\n");
>> +            break;
>> +
> 
> Where does this one come from?
> 
Encountered during debugging, I just thought to have it printed.
But okay, I can move it into a separate patch.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                   zSeries & Storage
[email protected]                          +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to