On Thu, 2014-12-18 at 16:54 +0200, Ilias Tsitsimpis wrote: > On Tue, Dec 16, 2014 at 12:09AM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger <n...@linux-iscsi.org> > > > > Hi all, > > > > This series addresses two issues raised recently by Ilias wrt > > AllRegistrants reservation handling in target code that does not > > adhere to SPC-4 specification requirements. > > > > This first is a informational change to PR-IN READ_FULL_STATUS, > > that when an AllRegistrants reservation is in place, all active > > registrations should be setting R_HOLDER=1 within their respective > > descriptors. > > > > The second is a functional change to PR-OUT REGISTER w/ SARK=0 > > operation, to avoid dropping the AllRegistrants reservation until > > the last registered I_T nexus has been released. It also ensures > > that the correct reservation type + scope is retained when the > > new reservation is set within __core_scsi3_complete_pro_release() > > for this AllRegistrants special case. > > > > Also, thanks to James for the extra SPC-4 clarifications. > > > > Please review. > > Hi Nicholas, > > Thanks for the quick fix. These patches address the two issues that I > raised in my previous email but they don't seem to fix all the problems > with AllRegistrants reservation handling in target code. Please see my > example below. >
<SNIP> > Now let's try to get a persistent reservation with the same type from > node2. SPC4r17 (par. 5.7.9 Reserving) states that: > > If the device server receives a PERSISTENT RESERVE OUT command with > RESERVE service action where the TYPE field and the SCOPE field > contain the same values as the existing type and scope from a > persistent reservation holder, it shall not make any change to the > existing persistent reservation and shall complete the command with > GOOD status. > > Node2 *is* a persistent reservation holder based on the wording of > SPC4r17 (par. 5.7.10 Persistent reservation holder). > But instead: > > root@node2:~# sg_persist --out --reserve -T 8 --param-rk 0x2 /dev/sdc > LIO-ORG FILEIO 4.0 > Peripheral device type: disk > persistent reserve out: scsi status: Reservation Conflict > PR out: command failed > > and on the target machine I get: > > [95713.681066] SPC-3 PR: Attempted RESERVE from [iSCSI]: > iqn.1993-08.org.debian:01:node2 while reservation already held by > [iSCSI]: iqn.1993-08.org.debian:01:node1, returning > RESERVATION_CONFLICT > > If I try the same from node1, the target completes the command with GOOD > status. > > > It is clear that the target code still considers node1 as the (only) > reservation holder and only *reports* node2 as being a reservation > holder. That is a very small change. Sending out a patch for this now. > > I believe we should fix the above errors by changing the > 'pr_res_holder' inside the 't10_reservation' struct to be a list of > holders rather than trying to handle this implicitly. Having a single > holder in the code seems prone to more errors similar to this one. > Not exactly, changing all existing code for ALLREG related special cases really isn't worth the extra pain here. I'd much rather identify any remaining ALLREG specific issues, and address them individually. Thanks Ilias! --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
