On Fri, Jan 22, 2016 at 03:42:41PM +0100, Hannes Reinecke wrote: > If MODE SELECT returns with sense '05/91/36' (command lock violation) > it should always be retried without counting the number of retries. > During an HBA upgrade or similar circumstances one might see a flood > of MODE SELECT command from various HBAs, which will easily trigger > the sense code and exceed the retry count. > > References: bsc#956949
Without the bugzilla refrence Reviewed-by: Johannes Thumshirn <[email protected]> > > Signed-off-by: Hannes Reinecke <[email protected]> > --- > drivers/scsi/device_handler/scsi_dh_rdac.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c > b/drivers/scsi/device_handler/scsi_dh_rdac.c > index 3613581..93880ed 100644 > --- a/drivers/scsi/device_handler/scsi_dh_rdac.c > +++ b/drivers/scsi/device_handler/scsi_dh_rdac.c > @@ -562,7 +562,7 @@ static int mode_select_handle_sense(struct scsi_device > *sdev, > /* > * Command Lock contention > */ > - err = SCSI_DH_RETRY; > + err = SCSI_DH_IMM_RETRY; > break; > default: > break; > @@ -612,6 +612,8 @@ retry: > err = mode_select_handle_sense(sdev, h->sense); > if (err == SCSI_DH_RETRY && retry_cnt--) > goto retry; > + if (err == SCSI_DH_IMM_RETRY) > + goto retry; > } > if (err == SCSI_DH_OK) { > h->state = RDAC_STATE_ACTIVE; > -- > 1.8.5.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Johannes Thumshirn Storage [email protected] +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
