On 02/07/2017 02:19 PM, Christoph Hellwig wrote: > Patch 1-7 look fine to me with minor fixups, and I'd love to see > them go into 4.11. The last one looks really questionable, > and 8 and 9 will need some work so that the MPT passthrough ioctls > either go away or make use of struct request and the block layer > and SCSI infrastructure. > Hmm. Which is quite a bit of effort for very little gain.
The SCSI passthrough commands pass in pre-formatted SGLs, so the driver just has to map them. If we were converting that we first have to re-format the (driver-specific) SGLs into linux sg lists, only to have them converted back into driver-specific ones once queuecommand is called. You sure it's worth the effort? The driver already reserves some tags for precisely this use-case, so it won't conflict with normal I/O operation. So where's the problem with that? I know the SCSI passthrough operations are decidedly ugly, but if I were to change them I'd rather move them over to bsg once we converted bsg to operate without a request queue. But for now ... not sure. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
