On 04/10/2017 07:12 PM, Sebastian Andrzej Siewior wrote: > The driver creates its own per-CPU threads which are updated based on CPU > hotplug events. It is also possible to use kworkers and remove some of the > infrastructure get the same job done while saving a few lines of code. > > bnx2fc_percpu_io_thread() becomes bnx2fc_percpu_io_work() which is > mostly the same code. The outer loop (kthread_should_stop()) gets > removed and the remaining code is shifted to the left. > In bnx2fc_process_new_cqes() the code checked for ->iothread to > decide if there is an active per-CPU thread. With the kworkers this > is no longer possible nor required. The allocation of a new work item > (via bnx2fc_alloc_work()) does no longer happen with the ->fp_work_lock > lock held. It performs only a memory allocation + initialization which > does not require any kind of serialization. The lock is held while > adding the new member to fps->work_list list. > > The remaining part is the removal CPU hotplug notifier since it is taken > care by the workqueue code. > > This patch was only compile-tested due to -ENODEV. > > Cc: [email protected] > Cc: Christoph Hellwig <[email protected]> > Signed-off-by: Sebastian Andrzej Siewior <[email protected]> > ---
Reviewed-by: Johannes Thumshirn <[email protected]>
