On 06/16/2017 07:56 AM, James Smart wrote:
> Removed unnecessary bzero of context area. Due to size of sg list,
> added a substantial delay and played havoc on cpu caches.
> 
> Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com>
> Signed-off-by: James Smart <james.sm...@broadcom.com>
> ---
>  drivers/scsi/lpfc/lpfc_nvmet.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index dba1bd216be3..431faa0a4f3e 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -205,7 +205,6 @@ lpfc_nvmet_ctxbuf_post(struct lpfc_hba *phba, struct 
> lpfc_nvmet_ctxbuf *ctx_buf)
>               sid = sli4_sid_from_fc_hdr(fc_hdr);
>  
>               ctxp = (struct lpfc_nvmet_rcv_ctx *)ctx_buf->context;
> -             memset(ctxp, 0, sizeof(ctxp->ctx));
>               ctxp->wqeq = NULL;
>               ctxp->txrdy = NULL;
>               ctxp->offset = 0;
> @@ -1422,7 +1421,6 @@ lpfc_nvmet_unsol_fcp_buffer(struct lpfc_hba *phba,
>                               "6414 NVMET Context corrupt %d %d oxid x%x\n",
>                               ctxp->state, ctxp->entry_cnt, ctxp->oxid);
>       }
> -     memset(ctxp, 0, sizeof(ctxp->ctx));
>       ctxp->wqeq = NULL;
>       ctxp->txrdy = NULL;
>       ctxp->offset = 0;
> 
Reviewed-by: Hannes Reinecke <h...@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Teamlead Storage & Networking
h...@suse.de                                   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

Reply via email to