On 06/16/2017 07:56 AM, James Smart wrote: > OS crashes after the completion of firmware download. > > Failure in posting SCSI SGL buffers because number of SGL buffers > is less than total count. Some of the pending IOs are not completed > by driver. SGL buffers for these IOs are not added back to the list. > Pending IOs are not completed because lpfc_wq_list list is > initialized before completion of pending IOs. > > Postpone lpfc_wq_list reinitialization by moving > lpfc_sli4_queue_destroy() after lpfc_hba_down_post(). > > Signed-off-by: Dick Kennedy <dick.kenn...@broadcom.com> > Signed-off-by: James Smart <james.sm...@broadcom.com> > --- > drivers/scsi/lpfc/lpfc_sli.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c > index 4f2cc395597e..8de70b9d79dd 100644 > --- a/drivers/scsi/lpfc/lpfc_sli.c > +++ b/drivers/scsi/lpfc/lpfc_sli.c > @@ -4303,7 +4303,6 @@ lpfc_sli4_brdreset(struct lpfc_hba *phba) > > /* Perform FCoE PCI function reset before freeing queue memory */ > rc = lpfc_pci_function_reset(phba); > - lpfc_sli4_queue_destroy(phba); > > /* Restore PCI cmd register */ > pci_write_config_word(phba->pcidev, PCI_COMMAND, cfg_value); > @@ -4428,6 +4427,7 @@ lpfc_sli_brdrestart_s4(struct lpfc_hba *phba) > pci_disable_pcie_error_reporting(phba->pcidev); > > lpfc_hba_down_post(phba); > + lpfc_sli4_queue_destroy(phba); > > return rc; > } > Reviewed-by: Hannes Reinecke <h...@suse.com>
Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
