On 08/23/2017 11:39 PM, Bart Van Assche wrote: > This patch avoids that smatch reports the following: > > drivers/scsi/scsi_sysfs.c:506 scsi_bus_uevent() warn: argument 3 to %02x > specifier has type 'char' > drivers/scsi/scsi_sysfs.c:872 sdev_show_modalias() warn: argument 4 to %02x > specifier has type 'char' > > Signed-off-by: Bart Van Assche <[email protected]> > Cc: Christoph Hellwig <[email protected]> > Cc: Hannes Reinecke <[email protected]> > Cc: Johannes Thumshirn <[email protected]> > --- > include/scsi/scsi_device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h > index 0979a5f3b69a..f054f3f43c75 100644 > --- a/include/scsi/scsi_device.h > +++ b/include/scsi/scsi_device.h > @@ -111,7 +111,7 @@ struct scsi_device { > unsigned sector_size; /* size in bytes */ > > void *hostdata; /* available to low-level driver */ > - char type; > + unsigned char type; > char scsi_level; > char inq_periph_qual; /* PQ from INQUIRY data */ > struct mutex inquiry_mutex; > Reviewed-by: Hannes Reinecke <[email protected]>
Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
