On 08/23/2017 11:39 PM, Bart Van Assche wrote: > This patch avoids that smatch reports the following warning: > > drivers/scsi/scsi_sysfs.c:117: check_set() error: strncmp() '"-"' too small > (2 vs 20) > > Signed-off-by: Bart Van Assche <[email protected]> > Cc: Christoph Hellwig <[email protected]> > Cc: Hannes Reinecke <[email protected]> > Cc: Johannes Thumshirn <[email protected]> > --- > drivers/scsi/scsi_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c > index 41891db20108..5ed473a87589 100644 > --- a/drivers/scsi/scsi_sysfs.c > +++ b/drivers/scsi/scsi_sysfs.c > @@ -114,7 +114,7 @@ static int check_set(unsigned long long *val, char *src) > { > char *last; > > - if (strncmp(src, "-", 20) == 0) { > + if (strcmp(src, "-") == 0) { > *val = SCAN_WILD_CARD; > } else { > /* > Reviewed-by: Hannes Reinecke <[email protected]>
Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
