Hi Geert,

On Tue, Mar 6, 2018 at 8:48 PM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote:
> BTW, please call the probe/remove functions zorro_esp_probe() resp.
> zorro_esp_remove().

Fair enough.

>>>> +       if (!host) {
>>>> +               pr_err(PFX "No host detected; board configuration 
>>>> problem?\n");
>>>> +               goto out_free;
>>>> +       }
>> here. But I can add the err=-NOMEM here.
> After out_free it returns fixed -ENODEV ;-)

Fixed that in my tree already. But I now have six err=-ENOMEM peppered
all over the probe code. Still, if it makes it more readable ...

> Doing "err = -ENOMEM" here, and returning err at the end is better, as
> it propagates meaningful error codes.

Yes, I've belatedly realized that now.

The major obstacle now seems to be dynamic allocation of the driver
private data and storing a pointer to that in a way that it can be
retrieved using just the esp pointer. dev_set_drvdata(esp->dev, zep)
causes the module load to crash ...



> Gr{oetje,eeting}s,
>                         Geert
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
> ge...@linux-m68k.org
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
>                                 -- Linus Torvalds

Reply via email to