Thanks,
Avri
> -----Original Message-----
> From: Bart Van Assche
> Sent: Wednesday, August 01, 2018 6:36 PM
> To: h...@lst.de; Avri Altman ; linux-scsi@vger.kernel.org;
> jthumsh...@suse.de; h...@suse.com; martin.peter...@oracle.com;
> j...@linux.vnet.ibm.com
> Cc: Vinayak Holikatti ; Avi Shchislowski ; Alex Lemberg ; Stanislav Nijnikov ;
> subha...@codeaurora.org
> Subject: Re: [PATCH 4/6] scsi: ufs: Add API to execute raw upiu commands
>
> On Wed, 2018-08-01 at 11:04 +0300, Avri Altman wrote:
> > +/**
> > + * ufshcd_exec_raw_upiu_cmd - API function for sending raw upiu
> commands
> > + * @hba: per-adapter instance
> > + * @req_upiu: upiu request - 8 dwards
> > + * @rsp_upiu: upiu reply - 8 dwards
> > + * @msgcode: message code, one of UPIU Transaction Codes
> Initiator to Target
> > + * @desc_buff: pointer to descriptor buffer, NULL if NA
> > + * @buff_len: descriptor size, 0 if NA
> > + * @rw: either READ or WRITE
> > + *
> > + * Supports UTP Transfer requests (nop and query), and UTP Task
> > + * Management requests.
> > + * It is up to the caller to fill the upiu conent properly, as it will
> > + * be copied without any further input validations.
> > + */
> > +int ufshcd_exec_raw_upiu_cmd(struct ufs_hba *hba,
> > + __be32 *req_upiu, __be32 *rsp_upiu,
> > + int msgcode,
> > + u8 *desc_buff, int *buff_len, int rw)
> > +{
>
> Again, what are "dwards"?
>
> Documenting the size of a data structure in a function header is very weird.
> Please change the data type of req_upiu and rsp_upio into a pointer to a
> structure of the proper size.
Ok.
>
> Thanks,
>
> Bart.
>
