Thanks, Avri > -----Original Message----- > From: Bart Van Assche > Sent: Wednesday, August 01, 2018 6:39 PM > To: [email protected]; Avri Altman ; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected] > Cc: Vinayak Holikatti ; Avi Shchislowski ; Alex Lemberg ; Stanislav Nijnikov ; > [email protected] > Subject: Re: [PATCH 6/6] scsi: ufs-bsg: Add support for uic commands in > ufs_bsg_request() > > On Wed, 2018-08-01 at 11:04 +0300, Avri Altman wrote: > > + struct uic_command uc = {0}; > > Please use "{ }" or "{}" for structure initialization as is done elsewhere in > the kernel instead of "{0}". Done.
> > > +#define UIC_CMD_SIZE (sizeof(u32) * 4) > > Please add a comment above this definition that explains whether this > constant > comes from the spec or whether it has another origin. Done. > > Thanks, > > Bart.
