Thanks,
Avri

> -----Original Message-----
> From: Bart Van Assche
> Sent: Wednesday, August 08, 2018 7:39 PM
> To: [email protected]; Avri Altman ; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]
> Cc: Vinayak Holikatti ; Avi Shchislowski ; Alex Lemberg ; Stanislav Nijnikov ;
> [email protected]
> Subject: Re: [PATCH v2 6/8] scsi: ufs: Add API to execute raw upiu commands
> 
> On Sun, 2018-08-05 at 14:39 +0300, Avri Altman wrote:
> > +   lrbp->command_type = (hba->ufs_version == UFSHCI_VERSION_10
> ||
> > +                         hba->ufs_version == UFSHCI_VERSION_11) ?
> > +                         UTP_CMD_TYPE_DEV_MANAGE :
> > +                         UTP_CMD_TYPE_UFS_STORAGE;
> 
> Parentheses are not needed around the logical or expression because logical
> or has a higher precedence than ?: so please leave the parentheses out.
Done.


> 
> Thanks,
> 
> Bart.

Reply via email to