Re: [patch] possible SMP races all over the place in wait_event

[Jeremy Fitzhardinge]

On 17-Aug-99 Andrea Arcangeli wrote:
> On Mon, 16 Aug 1999, Linus Torvalds wrote:
> 
>>So about half of your patch is unnecessary, but the latter half looks
>>valid.
> 
> I checked the 2.3.13 kernel sources wrt the wait_event SMP race.
> Here it is a fix against 2.3.13:

Wouldn't it be cleaner to define a macro in linux/sched.h 

#define SET_TASK_STATE(s)       do { current->state = (s); mb(); } while(0)

and replace all the explicit assignments with the macro?

        J
-
Linux SMP list: FIRST see FAQ at http://www.irisa.fr/prive/mentre/smp-faq/
To Unsubscribe: send "unsubscribe linux-smp" to [EMAIL PROTECTED]