Re: [patch] possible SMP races all over the place in wait_event interface

[Ingo Molnar]

instead of:

                current->state = TASK_INTERRUPTIBLE;
+               mb();

shouldnt we do:

+               xchgl(&current->state, TASK_INTERRUPTIBLE);

This 'merges' the barrier and the write. Or rather, in asm-i386 we could
do something like: 

#define set_mb(addr,val) xchgl(addr,val)

and then use set_barrier().

-- mingo

-
Linux SMP list: FIRST see FAQ at http://www.irisa.fr/prive/mentre/smp-faq/
To Unsubscribe: send "unsubscribe linux-smp" to [EMAIL PROTECTED]