Hi Mark, On Thursday 28 November 2013 10:34:07 Mark Brown wrote: > On Thu, Nov 28, 2013 at 02:39:43AM +0100, Laurent Pinchart wrote: > > Get the driver ready for the migration to the common clock framework by > > calling clk_prepare() and clk_unprepare(). The calls are added in the > > probe and remove handlers as the clk_enable() and clk_disable() calls > > are located in atomic context and there's no callback function in > > non-atomic context that can be used to prepare/unprepare the clock. > > Applied, thanks. However it does seem like you should be able to move > the prepare and disable to runtime PM rather than leaving it prepared > for the entire time the driver is loaded. In most systems this won't > make any difference since prepare won't do anything but it's a bit > neater.
It would be, but I believe the driver is currently broken in that regard. It calls the runtime PM sync API with a spinlock held, which if I'm not mistaken isn't right. That should be fixed, but is a bit out of scope of this work, hence the simple solution. -- Regards, Laurent Pinchart
signature.asc
Description: This is a digitally signed message part.
