On Thu, Nov 28, 2013 at 03:16:19PM +0100, Laurent Pinchart wrote: > On Thursday 28 November 2013 10:34:07 Mark Brown wrote:
> > Applied, thanks. However it does seem like you should be able to move > > the prepare and disable to runtime PM rather than leaving it prepared > > for the entire time the driver is loaded. In most systems this won't > > make any difference since prepare won't do anything but it's a bit > > neater. > It would be, but I believe the driver is currently broken in that regard. It > calls the runtime PM sync API with a spinlock held, which if I'm not mistaken > isn't right. That should be fixed, but is a bit out of scope of this work, > hence the simple solution. Yeah, that's broken and should be fixed - like I say I doubt it'll matter either way in practical systems if the clock is prepared all the time anyway.
signature.asc
Description: Digital signature
