On Monday, December 09, 2013 10:12 PM, Gerhard Sittig wrote: > On Mon, Dec 09, 2013 at 19:13 +0900, Jingoo Han wrote: > > > > Use devm_*() functions to make cleanup paths simpler. > > > > Signed-off-by: Jingoo Han <[email protected]> > > --- > > drivers/spi/spi-mpc512x-psc.c | 17 +++++------------ > > 1 file changed, 5 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c > > index 2babea2..77c03e2 100644 > > --- a/drivers/spi/spi-mpc512x-psc.c > > +++ b/drivers/spi/spi-mpc512x-psc.c > > @@ -503,7 +503,7 @@ static int mpc512x_psc_spi_do_probe(struct device *dev, > > u32 regaddr, > > master->cleanup = mpc512x_psc_spi_cleanup; > > master->dev.of_node = dev->of_node; > > > > - tempp = ioremap(regaddr, size); > > + tempp = devm_ioremap(dev, regaddr, size); > > if (!tempp) { > > dev_err(dev, "could not ioremap I/O port range\n"); > > ret = -EFAULT; > > @@ -513,8 +513,8 @@ static int mpc512x_psc_spi_do_probe(struct device *dev, > > u32 regaddr, > > mps->fifo = > > (struct mpc512x_psc_fifo *)(tempp + sizeof(struct mpc52xx_psc)); > > > > - ret = request_irq(mps->irq, mpc512x_psc_spi_isr, IRQF_SHARED, > > - "mpc512x-psc-spi", mps); > > + ret = devm_request_irq(dev, mps->irq, mpc512x_psc_spi_isr, IRQF_SHARED, > > + "mpc512x-psc-spi", mps); > > if (ret) > > goto free_master; > > init_completion(&mps->txisrdone); > > nit: whitespace, indentation of the continued parameter list
Hi Gerhard Sittig, Sorry, I cannot find the whitespace. Also, there is no checkpatch warning. Would you check it again? :-) Thank you for your feedback. Best regards, Jingoo Han > > everything else looks good (from looking at it, did not build/run-test) -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
