On Tue, Dec 10, 2013 at 11:13 +0900, Jingoo Han wrote: > > On Monday, December 09, 2013 10:12 PM, Gerhard Sittig wrote: > > > > On Mon, Dec 09, 2013 at 19:13 +0900, Jingoo Han wrote: > > > > > [ ... ] > > > @@ -513,8 +513,8 @@ static int mpc512x_psc_spi_do_probe(struct device > > > *dev, u32 regaddr, > > > mps->fifo = > > > (struct mpc512x_psc_fifo *)(tempp + sizeof(struct mpc52xx_psc)); > > > > > > - ret = request_irq(mps->irq, mpc512x_psc_spi_isr, IRQF_SHARED, > > > - "mpc512x-psc-spi", mps); > > > + ret = devm_request_irq(dev, mps->irq, mpc512x_psc_spi_isr, IRQF_SHARED, > > > + "mpc512x-psc-spi", mps); > > > if (ret) > > > goto free_master; > > > init_completion(&mps->txisrdone); > > > > nit: whitespace, indentation of the continued parameter list > > Hi Gerhard Sittig, > > Sorry, I cannot find the whitespace. > Also, there is no checkpatch warning. > Would you check it again? :-) > Thank you for your feedback.
If you look very close at the added lines, you see that the continued line (the opening quote of the string) does not align with the start of the parameter list of the previous line (the 'dev' word). And it appears to not be a false positive due to the use of TABs, as in the above quote the "ret = " starts at position 8 as well. But as mentioned, it's a nit. And if nobody else objects neither will I. It's just too minor, and does not affect operation. virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
