On Monday, December 16, 2013 at 09:58:50 AM, Huang Shijie wrote:
[...]
> +/* Macros for constructing the LUT register. */
> +#define LUT0(ins, pad, opr) \
> + (((opr) << OPRND0_SHIFT) | ((LUT_##pad) << PAD0_SHIFT) | \
> + ((LUT_##ins) << INSTR0_SHIFT))
> +
> +#define LUT1(ins, pad, opr) (LUT0(ins, pad, opr) << OPRND1_SHIFT)
Change this into an inline function, that way you'd get type-checking here.
[...]
> +enum fsl_qspi_devtype {
> + FSL_QUADSPI_VYBRID,
> + FSL_QUADSPI_IMX6SLX
Will the SLX be only a single-core chip?
> +};
> +
> +struct fsl_qspi_devtype_data {
> + enum fsl_qspi_devtype devtype;
> + u32 memmap_base;
> + int rxfifo;
> + int txfifo;
> +};
> +
> +static struct fsl_qspi_devtype_data vybrid_data = {
> + .devtype = FSL_QUADSPI_VYBRID,
> + .memmap_base = 0x20000000,
This memmap_base should come from DT prop.
> + .rxfifo = 128,
> + .txfifo = 64
Ditto for both of these too. They're HW props.
> +};
[...]
Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
