On Sun, Jul 27, 2014 at 11:53:20PM +0200, Thomas Petazzoni wrote: > @@ -150,6 +151,11 @@ orion_spi_setup_transfer(struct spi_device *spi, struct > spi_transfer *t) > if (rc) > return rc; > > + orion_spi_clrbits(orion_spi, ORION_SPI_IF_CTRL_REG, > + ORION_SPI_CS_MASK); > + orion_spi_setbits(orion_spi, ORION_SPI_IF_CTRL_REG, > + ORION_SPI_CS(spi->chip_select)); > + > if (bits_per_word == 16) > orion_spi_setbits(orion_spi, ORION_SPI_IF_CONFIG_REG, > ORION_SPI_IF_8_16_BIT_MODE);
I would expect to see this chip select manipulation to be being done in set_cs not in setup_transfer() otherwise we'll probably get surprised when the driver is converted to use transfer_one() and pull the chip select handling out of the driver (among other things).
signature.asc
Description: Digital signature
