Hi, On 03/27/2014 11:19 AM, Hans de Goede wrote:
<snip> >>> + host->reset = devm_reset_control_get(&pdev->dev, "reset"); >> >> You can probably use reset_control_get_optional here (not that it >> matters much in this case, but anyway...) > > That does not exist: > http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/include/linux/reset.h > > Only the regulator framework has this _optional thing which you need to use > to avoid it logging errors. In the phy / reset case you're expected to log an > error yourself if an error is fatal and there only is a standard _get (AFAIK). > >> >>> + if (IS_ERR(host->reset)) >>> + host->reset = NULL; /* Having a reset controller is optional */ >>> + >> >> And you should handle EPROBE_DEFER too. > > A yes, good one, will fix. David I'm going to fix this in my personal tree, if > you merge the reset controller code into the existing mmc patches, please make > sure you take the latest version of the patch from my personal tree. Erm, scrap that I've just checked this and devm_reset_control_get will never return EPROBE_DEFER, so there is no need for the code to handle it here. Regards, Hans -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
