On Thu, Mar 27, 2014 at 11:24:34AM +0100, Hans de Goede wrote:
> Hi,
>
> On 03/27/2014 10:58 AM, Maxime Ripard wrote:
> > On Wed, Mar 26, 2014 at 09:17:59PM +0100, Hans de Goede wrote:
> >> Signed-off-by: Hans de Goede <hdego...@redhat.com>
> >> ---
> >> arch/arm/boot/dts/sun6i-a31.dtsi | 59
> >> ++++++++++++++++++++++++++++++++++++++++
> >> 1 file changed, 59 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi
> >> b/arch/arm/boot/dts/sun6i-a31.dtsi
> >> index 45b5775..8fa124b 100644
> >> --- a/arch/arm/boot/dts/sun6i-a31.dtsi
> >> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi
> >> @@ -307,6 +307,58 @@
> >> #dma-cells = <1>;
> >> };
> >>
> >> + mmc0: mmc@01c0f000 {
> >> + compatible = "allwinner,sun5i-a13-mmc";
> >> + reg = <0x01c0f000 0x1000>;
> >> + clocks = <&ahb1_gates 8>, <&mmc0_clk>;
> >> + clock-names = "ahb", "mod";
> >> + resets = <&ahb1_rst 8>;
> >> + reset-names = "reset";
> >
> > You don't need the reset-names iirc.
>
> Hmm, looking at drivers/reset/core.c it looks like your right, if I
> pass in NULL as id to devm_reset_control_get it will just take the first one.
> So then the question becomes do we ever expect to need a second reset? The
> advantage
> of using names right away is that adding a second reset becomes a lot cleaner.
> So my vote goes to keeping the name.Works for me, but use a meaningful name then :) something like ahb, to be consistent with the clocks maybe? -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
signature.asc
Description: Digital signature
