On Thu, 2014-03-27 at 23:42 +0100, Olliver Schinagl wrote: > On 03/27/2014 10:06 PM, Ian Campbell wrote: > > On Tue, 2014-03-25 at 11:00 +0100, [email protected] wrote: > >> From: Olliver Schinagl <[email protected]> > >> > >> This patch cleans up several macro's to remove magic values etc from > >> clock.c and clock.h. Casualties being dragged in are some macro's from > >> dram.c and the i2c driver. > > > > This addresses (some of) Marek's review on the upstreaming series, is > > that right? > Yes, but this is just some of the stuff i had done for some early sunxi > review. I since have cleaned it up better, changed it a little; and with > you workflow explanation, have to redo it. On top of that, i have to > split it out in seperate patches *yay* > > I will work on that the next few days; but you now know what i'm doing, > and I know how to test it :)
Thanks! > so just diff the output of objdump -d is what you do? I should be able > to do that. For straight "replace a number with a #define" this diffing is what I would do. Unfortunately I suspect that the sr32->clrsetbits transformation will result in too much change in the generated code (a function call turns into some inline bit fiddling) to allow useful diffing of the resulting binary. I think for that patch you'll just have to do a runtime test. Good reason to split all the trivial replacements into separate patches though ;-) Ian. -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
