Hi Maxime, [let's hope this email goes through as non-empty]
El 10/05/14 00:33, Maxime Ripard escribió:
Since we have a folder of our own, we can actually make use of it by splitting the huge clock file into several sub drivers. The gmac clock is pretty easy to deal with, since it's pretty much isolated and doesn't have any dependency on the other clocks. Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> ---
Looks good to me, but see below.
drivers/clk/sunxi/Makefile | 3 +- drivers/clk/sunxi/clk-a20-gmac.c | 119 +++++++++++++++++++++++++++++++++++++++ drivers/clk/sunxi/clk-sunxi.c | 98 -------------------------------- 3 files changed, 121 insertions(+), 99 deletions(-) create mode 100644 drivers/clk/sunxi/clk-a20-gmac.c
(snip)
+ + clk = clk_register_composite(NULL, clk_name, + parents, SUN7I_A20_GMAC_PARENTS, + &mux->hw, &clk_mux_ops, + NULL, NULL, + &gate->hw, &clk_gate_ops, + 0); + + if (IS_ERR(clk)) + goto iounmap_reg; + + of_clk_add_provider(node, of_clk_src_simple_get, clk); + clk_register_clkdev(clk, clk_name, NULL);
As I mentioned on the other email, I don't think we are using clkdev. Maybe we can drop it.
Thanks for working on this! Emilio -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
