On Mon, May 12, 2014 at 04:45:08PM -0300, Emilio López wrote: > >>>+ clk = clk_register_composite(NULL, clk_name, > >>>+ parents, SUN7I_A20_GMAC_PARENTS, > >>>+ &mux->hw, &clk_mux_ops, > >>>+ NULL, NULL, > >>>+ &gate->hw, &clk_gate_ops, > >>>+ 0); > >>>+ > >>>+ if (IS_ERR(clk)) > >>>+ goto iounmap_reg; > >>>+ > >>>+ of_clk_add_provider(node, of_clk_src_simple_get, clk); > >>>+ clk_register_clkdev(clk, clk_name, NULL); > >> > >>As I mentioned on the other email, I don't think we are using > >>clkdev. Maybe we can drop it. > > > >No we aren't, but we should not really modify code while moving it. I > >can send another patch to do so, but that should not prevent this code > >from going in. > > That would be great :) The patches themselves are okay, I just > thought I'd mention it so it's not forgotten.
It's not, Boris reminded it to me a week ago :) Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
signature.asc
Description: Digital signature
