On Wed, 14 May 2014 18:10:38 +0300 Tsvetan Usunov <[email protected]> wrote:
> 2014-05-14 16:42 GMT+03:00 Hans de Goede <[email protected]>: > > Hi, > > > > On 05/07/2014 08:24 AM, Димитър Гамишев wrote: > >> Hi All, > >> this patch adds u-boot support for a13-som boards by Olimex > > > > AFAIK the a13-som is not officially released yet. It seems a > > bit early to add support for it, what if the final version is different. > > > > Also your patch is hopelessly mangled next time please use > > git send-email to send patches. > Hans, these are assembling now and will be on the web next week, so > there will be no differences To Tsvetan & Димитър: Could you please re-send the fixed patch? As Hans already pointed, it got scrambled somewhere on the way to the list and can't be applied as-is. Also the "Signed-off-by" tag in the commit message and the use of "git format-patch"/"git send-email" commands is pretty much required. You can check the following wiki page for the hints about configuring git: http://linux-sunxi.org/Mailing_list#Configuring_git_for_send-email And checking the other commits in the u-boot-sunxi repository may help to ensure that your patch adheres to a similar style and does not look out of place: https://github.com/linux-sunxi/u-boot-sunxi/commits/sunxi BTW, is 'a13-som' a really good name for this particular hardware? Maybe it should an explicit reference to 'Olimex' in the name? To Hans: IMHO waiting for the official release is not really necessary. And we have already seen the A13 SOM announcement: http://tinyurl.com/lp8mozc After all, Intel is bragging about having Linux support for their hardware in the mainline Linux kernel even before anyone else has any chance to see their hardware :-) If we get no A13 SOM support in the u-boot-sunxi in time, Olimex would have no other choice, but to instruct the users to use their own fork. This sometimes does not end well. -- Best regards, Siarhei Siamashka -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
