On Fri, Jun 13, 2014 at 09:32:20AM +0200, Hans de Goede wrote: > Hi, > > On 06/13/2014 12:48 AM, [email protected] wrote: > > On Thu, Jun 12, 2014 at 6:35 PM, Emilio López <[email protected]> wrote: > >> El 12/06/14 19:11, [email protected] escribió: > >> > >>> What has replaced sw_get_ic_ver() on 3.15? > >>> > >>> Codec code varies on every chip revision A,B,C and A10/20. > >> > >> > >> A10/A20 can be determined by the compatible string. Chip revision is going > >> to be trickier though, there is no direct replacement of sw_get_ic_ver() > >> that I'm aware of. sw_get_ic_ver() seems to poke a timer register in the > >> sun4i case, and SID (for which we do have a driver[1]) on the sun5i case. > >> > >> [1] drivers/misc/eeprom/sunxi_sid.c > > > > We may have to reimplement it. Codec driver has stuff like this in it. > > I think adding some sort of SoC version detection makes sense, so go for it.
It might, and we probably will come to it eventually, but I don't get what it would bring here. Have different compatible strings for the various revisions of the IP is much simpler and adds no code at all. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
signature.asc
Description: Digital signature
