On Mon, 2014-09-08 at 21:28 +0800, Chen-Yu Tsai wrote: > +#ifdef CONFIG_SPL_BUILD
Since there is no SPL support this is dead code right now, correct? I'm wondering whether we should leave it out of mainline until the SPL stuff is done, so SPL will be upstreamed all at once. What do others think? > + /* Set PLL ldo voltage without this PLL6 does not work properly */ Is "this" here the doing it 3 times bit? If that's deliberate then please say so explicitly. e.g. "Set PLL LDO voltage 3 times, without ... etc"), if it's not deliberate then please fix ;-) I'm assuming this is one of those "no docs, allwinner code did it but nobody knows why it works" scenarios. Of course if the reason is known/doc'd then please add a reference. > + writel(PRCM_PLL_CTRL_LDO_DIGITAL_EN | PRCM_PLL_CTRL_LDO_ANALOG_EN | > + PRCM_PLL_CTRL_EXT_OSC_EN | PRCM_PLL_CTRL_LDO_OUT_L(1140) | > + PRCM_PLL_CTRL_LDO_KEY, &prcm->pll_ctrl1); > + writel(PRCM_PLL_CTRL_LDO_DIGITAL_EN | PRCM_PLL_CTRL_LDO_ANALOG_EN | > + PRCM_PLL_CTRL_EXT_OSC_EN | PRCM_PLL_CTRL_LDO_OUT_L(1140) | > + PRCM_PLL_CTRL_LDO_KEY, &prcm->pll_ctrl1); > + writel(PRCM_PLL_CTRL_LDO_DIGITAL_EN | PRCM_PLL_CTRL_LDO_ANALOG_EN | > + PRCM_PLL_CTRL_EXT_OSC_EN | PRCM_PLL_CTRL_LDO_OUT_L(1140), > + &prcm->pll_ctrl1); [...] Ian. -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
