On Tue, Jan 20, 2015 at 10:13:05AM +0800, Chen-Yu Tsai wrote:
> >> + clk_parent = of_clk_get_parent_name(np, 0);
> >> + if (!clk_parent)
> >> + return -EINVAL;
> >> +
> >> + data->clk = devm_clk_get(&pdev->dev, NULL);
> >> + if (IS_ERR(data->clk)) {
> >> + dev_err(&pdev->dev, "Could not get clock\n");
> >> + return PTR_ERR(data->clk);
> >> + }
> >
> > I'm wondering, why are you using of_clk_get_parent_name here, instead
> > of __clk_get_name on data->clk? That would avoid parsing the DT while
> > we already have that info.
>
> I hadn't thought of that. I was sticking to public consumer APIs.
> Do you want me to respin this one?I don't think it's really a !consumer API. All it does is returning clk->name, which is accessible even to consumers. But yeah, please resend it. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: Digital signature
